Fixes memory leaks for nested fields #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates memory allocation out from convert_from_py function. Now it uses separate create_message function to allocate message, making it explicit gives better control where and how memory is allocated and freed.
sloretz
reviewed
Jul 12, 2018
| } | ||
| @[ if field.type.array_size is None or field.type.is_upper_bound]@ | ||
| Py_ssize_t size = PySequence_Size(field); | ||
| if (-1 == size) { | ||
| Py_DECREF(seq_field); | ||
| Py_DECREF(field); | ||
| return NULL; | ||
| return false; | ||
| } | ||
| if (!@(nested_type)__Array__init(&(ros_message->@(field.name)), size)) { |
There was a problem hiding this comment.
Still wrapping my head around the message generation code. What checks that ros_message is not NULL before this point?
There was a problem hiding this comment.
In current code caller checks in _rclpy.c after it allocated it with create_ros_message. I can add explicit check here, but current code already was not checking any other arguments like _pymsg or raw_ros_message, so I did not add any extra checks for this new argument.
13 tasks
dirk-thomas
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates memory allocation out from convert_from_py function. Now it uses separate create_message function to allocate message, making it explicit gives better control where and how memory is allocated and freed.
See #5 for details.