Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-package from ament_target_dependencies() #76

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Remove non-package from ament_target_dependencies() #76

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae069f6
Remove non-package from ament_target_dependencies()
sloretz Jul 24, 2019
48380e6
Remove linking call since it wasn't needed before
sloretz Jul 24, 2019
8334b82
Comment why setting _FOUND
sloretz Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rosidl_generator_py/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ if(BUILD_TESTING)
include(cmake/register_py.cmake)
include(cmake/rosidl_generator_py_get_typesupports.cmake)

set(rosidl_generator_py_FOUND "1")
jacobperron marked this conversation as resolved.
Show resolved Hide resolved
set(rosidl_generator_py_DIR "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

# Need to call extras before get_typesupports, to register the extension
Expand Down
1 change: 0 additions & 1 deletion rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ foreach(_typesupport_impl ${_typesupport_impls})
ament_target_dependencies(${_target_name}
"rosidl_generator_c"
"rosidl_generator_py"
"${rosidl_generate_interfaces_TARGET}__rosidl_generator_c"
)

if(NOT rosidl_generate_interfaces_SKIP_INSTALL)
Expand Down