Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .gitignore #5

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Add .gitignore #5

merged 1 commit into from
Nov 2, 2019

Conversation

galou
Copy link
Contributor

@galou galou commented Oct 23, 2019

No description provided.

@mjcarroll
Copy link
Member

For consistency, we should also ignore *.pyc, as we do in other python repositories.

Also, you will need to signoff your commits by doing git commit -s in order to pass DCO checks.

@mjcarroll mjcarroll mentioned this pull request Oct 23, 2019
Merged
@galou
Copy link
Contributor Author

galou commented Oct 24, 2019

Is Python2 supported is ROS2?

@mjcarroll
Copy link
Member

It is not. Purely Python3.

@mjcarroll
Copy link
Member

Oh yes, I see what you are saying, __pycache__ should be sufficient in python3. Just a signoff, then.

@galou
Add .gitignore
95cf73c 
Signed-off-by: Gaël Écorchard <gael.ecorchard@cvut.cz>
@galou
Copy link
Contributor Author

galou commented Oct 30, 2019

Signed-off.

jacobperron
jacobperron approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacobperron jacobperron merged commit 694c2b4 into ros2:master Nov 2, 2019
@galou galou deleted the gitignore branch November 4, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@galou @mjcarroll @jacobperron