Add special case for importing action feedback message #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support getting the feedback message type used to communicate between action servers and action clients. The feedback message type can be used to introspect action goals with tools like ros2topic. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
reviewed
Dec 2, 2019
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Dec 2, 2019
Edit: the ros2cli tests appear flakey.. I can reproduce the failures locally with master branches as well. |
jacobperron
added a commit
to ros2/ros2cli
that referenced
this pull request
Dec 4, 2019
Connects to #218. Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError. The new logic added in ros2/rosidl_runtime_py#9 should fix the error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
to ros2/ros2cli
that referenced
this pull request
Dec 10, 2019
) Connects to #218. Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError. The new logic added in ros2/rosidl_runtime_py#9 should fix the error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support getting the feedback message type used to communicate between action servers and action clients.
The feedback message type can be used to introspect action goals with tools like ros2topic.
Note that currently,
ros2 topic echodoes not work with action feedback topics. I'll have a PR to https://github.com/ros2/ros2cli shortly that makes use of the import function modified here.Maybe it makes sense to push this logic into
rosidl_parser, but this gets the job done for now.