Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle and ensure the exportation of rosidl generated targets #113

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jun 24, 2021

Precisely what the title says. Connected to ros2/rosidl#601.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from ivanpauno and sloretz June 24, 2021 22:45
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Jun 29, 2021

Full CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Jun 29, 2021

@ivanpauno may I ask you to take a look here as well?

@hidmic hidmic merged commit 78fadb5 into master Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-target-exports branch June 30, 2021 14:50
hidmic added a commit that referenced this pull request Aug 4, 2021
…#113)"

This reverts commit 78fadb5.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic added a commit that referenced this pull request Aug 9, 2021
…#113)" (#116)

This reverts commit 78fadb5.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants