-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Typesupport Introspection tests #133
Fix Typesupport Introspection tests #133
Conversation
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@ros-pull-request-builder retest this please |
PR build is failing with a cache error:
How can we install that dependency into the agent? Or is it a missing dependency in general? FYI: @Blast545 @clalancette |
We're in the middle of a very large rebuild of Rolling. Rpr jobs are probably not going to work at the moment; just depend on CI for now. This should hopefully resolve itself later today. |
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@clalancette do we need to run RHEL? |
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me with one more green CI run.
* Update expected typesupport identifier Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This reverts commit 0ea986b.
This reverts commit 0ea986b. Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This reverts commit 0ea986b. Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This reverts commit 5a8445a.
Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com
After (#127) we have new 2 failing tests in Rolling CycloneDDS:
projectroot.test_service_typesupport_cpp log output:
projectroot.test_service_typesupport_c log output:
Reference build: https://build.ros2.org/view/Rci/job/Rci__nightly-cyclonedds_ubuntu_jammy_amd64/351/#showFailuresLink
This PR changes the expected
typesupport_identifier
so it matches the actual value.