typesupport_tests needs to be updated to C++17 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Mar 26, 2023
clalancette
requested changes
Mar 27, 2023
clalancette
approved these changes
Mar 27, 2023
|
CI:
|
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This reverts commit 0ea986b. Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
This reverts commit 5a8445a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #131 most of ros 2 support should be pushed towards C++17 and rosidl_typesupport_tests should be included to be consistent. Also, this was causing errors on MacOS and if it's such a miniscule change that doesn't cause issues in other places, there is no reason not to add C++17 support.