Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare string contents but string pointer addresses. #153

Merged
merged 1 commit into from Feb 29, 2024
Merged

compare string contents but string pointer addresses. #153

merged 1 commit into from Feb 29, 2024

Conversation

fujitatomoya
Copy link
Contributor

@fujitatomoya
compare string contents but string pointer addresses.
b36c09e 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
fujitatomoya commented Feb 28, 2024
View reviewed changes
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette @sloretz can either of you review this?

@fujitatomoya
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

quarkytale
quarkytale approved these changes Feb 29, 2024
View reviewed changes
Copy link

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me based on the discussion in the linked issue, not sure why the CI is unstable though.

@clalancette
Copy link
Contributor

Makes sense to me based on the discussion in the linked issue, not sure why the CI is unstable though.

The unstable CI is currently expected, since we are running things in parallel now and we have a few failing tests.

I'm going to go ahead and merge this one in, thanks @fujitatomoya

@clalancette clalancette merged commit b93beec into ros2:rolling Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@quarkytale quarkytale quarkytale approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fujitatomoya @clalancette @quarkytale