add and use groups for generator and runtime packages #25
Conversation
dirk-thomas
added
enhancement
dirk-thomas
added
in progress
|
dirk-thomas
added
in review
There was a problem hiding this comment.
change looks good to me, I didnt get a chance to try registering an additional generator to test it.
Maybe @esteve can confirm if it works for the java use case
| @@ -19,6 +19,7 @@ | |||
| <buildtool_export_depend>rosidl_typesupport_c</buildtool_export_depend> | |||
| <buildtool_export_depend>rosidl_typesupport_cpp</buildtool_export_depend> | |||
|
|
|||
| <group_depend>rosidl_generator_packages</group_depend> | |||
There was a problem hiding this comment.
do we still need to explicitly list all generators as build_export_depend here ? or do we keep it just to enforce that at least these 3 are present?
There was a problem hiding this comment.
They need to be explicit for packaging into Debians.
There was a problem hiding this comment.
👍 yeah that was my understanding.
+1 to merge it as is.
We will revisit after the release where the dependencies for packaging should be listed as we have a conflicting policy at the moment (comparing to ros1_bridge for example)
There was a problem hiding this comment.
This PR aims to ease integrating custom generators. Making currently required generators optional would be a different thing.
|
@esteve I will merge this change for now hoping it addresses your use case. Please comment after the fact so that we know it does (or doesn't 😟 and iterate on it). |
|
@dirk-thomas it works great, thanks! https://travis-ci.org/esteve/ros2_java/jobs/393401730 |
Requires ros2/rosidl#283.
The rosidl generator | runtime packages declare being a member of a group as well as register themselves at the resource index.
Additionally the default packages depend on their group and in CMake collect the available generator | runtime packages from the resource index instead of using a hard coded list (while keeping the mandatory ones explicitly listed in the manifest).