add groups for generator and runtime packages #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
This was referenced Jun 14, 2018
dirk-thomas
added
in progress
dirk-thomas
added
in review
mikaelarguedas
approved these changes
Jun 15, 2018
There was a problem hiding this comment.
change looks good to me, I didnt get a chance to try registering an additional generator to test it.
Maybe @esteve can confirm if it works for the java use case
|
@esteve I will merge this change for now hoping it addresses your use case. Please comment after the fact so that we know it does (or doesn't 😟 and iterate on it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rosidl generator | runtime packages declare being a member of a group as well as register themselves at the resource index.