Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generated IDL files #35

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Allow generated IDL files #35

merged 1 commit into from
Nov 9, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Oct 31, 2018

The target dependency won't exist at cmake configure time before the first build if it is generated, so don't FATAL_ERROR in that case.

connects to ros2/rcl_interfaces#47

@sloretz sloretz added the in progress Actively being worked on (Kanban column) label Oct 31, 2018
@sloretz sloretz self-assigned this Oct 31, 2018
@sloretz sloretz mentioned this pull request Nov 8, 2018
Merged
hidmic
hidmic approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sloretz sloretz merged commit e450c4d into master Nov 9, 2018
@sloretz sloretz deleted the sloretz/allow_generated_idl branch November 9, 2018 22:06
@sloretz sloretz removed the in progress Actively being worked on (Kanban column) label Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloretz @hidmic