Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces action interfaces CMake target name length to please Windows. #41

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Dec 7, 2018

Fixes ros2/build_farmer#154. Had to reduce the name length for action targets a bit. I did so everywhere for consistency.

@tfoote tfoote added the in progress Actively being worked on (Kanban column) label Dec 7, 2018
@hidmic
Copy link
Contributor Author

hidmic commented Dec 7, 2018

  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Dec 7, 2018

Ah it looks like the path in the nightly has the job name in it nightly_win_extra_rmw_release. It's possible ci_windows is short enough but nightly_win_extra_rmw_release isn't.

The change looks good but we won't know for sure until a nightly runs with this fix.

@hidmic
Copy link
Contributor Author

hidmic commented Dec 7, 2018

I've been testing out path lengths separately. Worst case seems to be:

C:\J\workspace\nightly_win_extra_rmw_release\ws\x08uild\example_interfaces\example_interfaces__rosidl_typesupport_cpp__generate_action_interfaces.dir\Release\example_.46C9518E.tlog\example_interfaces__rosidl_typesupport_cpp__generate_action_interfaces.lastbuildstate

That one has a total count of 266 characters. With this change, it goes down to 246 characters.

@clalancette
Copy link
Contributor

C:\J\workspace\nightly_win_extra_rmw_release

Separately, it might be a good idea to rename this job to nightly_win_extra_rmw_rel; not only is it shorter (gaining us a bit more headroom), it also matches job names like https://ci.ros2.org/view/nightly/job/nightly_win_rel/ .

@hidmic
Copy link
Contributor Author

hidmic commented Dec 7, 2018

Sounds good to me, though I'm not sure I have enough powers to do that. Do you @clalancette ?

@clalancette
Copy link
Contributor

Sounds good to me, though I'm not sure I have enough powers to do that. Do you @clalancette ?

Yeah, it starts with a change to https://github.com/ros2/ci/ . Once that is approved, merged, then I have to remember how to deploy it to the buildfarm :). I'll take a look at it in a little bit.

@nuclearsandwich
Copy link
Member

Yeah, it starts with a change to https://github.com/ros2/ci/ . Once that is approved, merged, then I have to remember how to deploy it to the buildfarm :). I'll take a look at it in a little bit.

In order to keep job history intact we'll rename the job via the jenkins UI

@hidmic
Copy link
Contributor Author

hidmic commented Dec 7, 2018

Thanks @sloretz ! Merging.

@hidmic hidmic merged commit af0980a into master Dec 7, 2018
@tfoote tfoote removed the in progress Actively being worked on (Kanban column) label Dec 7, 2018
@dirk-thomas dirk-thomas deleted the hidmic/trim-action-targets-names branch April 22, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants