-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduces action interfaces CMake target name length to please Windows. #41
Conversation
Ah it looks like the path in the nightly has the job name in it The change looks good but we won't know for sure until a nightly runs with this fix. |
I've been testing out path lengths separately. Worst case seems to be:
That one has a total count of 266 characters. With this change, it goes down to 246 characters. |
Separately, it might be a good idea to rename this job to |
Sounds good to me, though I'm not sure I have enough powers to do that. Do you @clalancette ? |
Yeah, it starts with a change to https://github.com/ros2/ci/ . Once that is approved, merged, then I have to remember how to deploy it to the buildfarm :). I'll take a look at it in a little bit. |
In order to keep job history intact we'll rename the job via the jenkins UI |
Thanks @sloretz ! Merging. |
Fixes ros2/build_farmer#154. Had to reduce the name length for action targets a bit. I did so everywhere for consistency.