Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ts for long double and wchar #26

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Conversation

dirk-thomas
Copy link
Member

Same as ros2/rosidl#383.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Jun 4, 2019
@dirk-thomas dirk-thomas self-assigned this Jun 4, 2019
@dirk-thomas dirk-thomas changed the title fix ts for long double fix ts for long double and wchar Jun 5, 2019
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Jun 5, 2019

Including the second commit addressing wchar support:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a couple questions and pending green CI

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas merged commit a48c7fa into master Jun 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-long-double branch June 5, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants