New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ament_cmake_ros #30

Merged

dirk-thomas merged 1 commit into master from dirk-thomas/use-ament_cmake_ros

Apr 15, 2020

Member

dirk-thomas commented Feb 13, 2020 •

edited

Loading

Allowing to choose between shared and static libraries.

Linux (same test also failing on master: https://ci.ros2.org/job/ci_linux/9336/)
Linux-aarch64 (same as Linux)
macOS (it seems the same tests are failing in the nightly - hard to tell with that number though)
Windows (PyQt failures unrelated to this change)
Windows-container

dirk-thomas added the enhancement label

dirk-thomas self-assigned this


          use ament_cmake_ros

931bec8

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

dirk-thomas force-pushed the dirk-thomas/use-ament_cmake_ros branch from ce0ad6c to 931bec8 Compare

April 14, 2020 22:20

Member Author

dirk-thomas commented Apr 14, 2020

CI builds using FastRTPS up to demo_nodes_cpp:

Linux
Linux-aarch64
macOS
Windows

jacobperron reviewed

View reviewed changes

Member

jacobperron left a comment

To help clarify, is the only difference when switching to ament_cmake_ros that BUILD_SHARED_LIBS is ON by default?

Member Author

dirk-thomas commented Apr 15, 2020 •

edited

Loading

It also adds a compiler definition for ROS_PACKAGE_NAME.

jacobperron approved these changes

View reviewed changes

dirk-thomas merged commit 5d05d8a into master

delete-merged-branch bot deleted the dirk-thomas/use-ament_cmake_ros branch

April 15, 2020 03:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels