Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move headers under detail subfolder and use modern cmake to fix single typesupport builds #40

Merged
merged 2 commits into from
May 20, 2020
Merged

Move headers under detail subfolder and use modern cmake to fix single typesupport builds #40

merged 2 commits into from
May 20, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented May 7, 2020 •
edited
Loading

Depends on ros2/rosidl#483.

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 7, 2020
@ivanpauno ivanpauno requested a review from dirk-thomas May 7, 2020 20:15
@ivanpauno ivanpauno self-assigned this May 7, 2020
@dirk-thomas
Copy link
Member

Please post CI builds before / after.

@ivanpauno
Copy link
Member Author

This will still fail, but running before and after jobs to show the difference:

  • Before Build Status
  • After Build Status

@ivanpauno
Copy link
Member Author

Depends on ros2/rosidl#483

@ivanpauno
Copy link
Member Author

  • After Build Status

If I delete the QUIET here https://github.com/ros2/rosidl/blob/f3f639df4cef29fda1dc18074fe0b1e2c3b108e6/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake#L145, the error is:

CMake Warning at /home/ivanpauno/ros2_ws/other_ws/investigating_build_connext_failure/install/rosidl_cmake/share/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake:145 (find_package):
  Found package configuration file:

    /home/ivanpauno/ros2_ws/other_ws/investigating_build_connext_failure/install/action_msgs/share/action_msgs/cmake/action_msgsConfig.cmake

  but it set action_msgs_FOUND to FALSE so package "action_msgs" is
  considered to be NOT FOUND.  Reason given by package:

  The following imported targets are referenced, but are missing:
  action_msgs::action_msgs__rosidl_typesupport_fastrtps_cpp

The problem is that though the target is correctly exported, action_msgs__rosidl_typesupport_fastrtps_c depends on it and it's included before.

@ivanpauno ivanpauno assigned ivanpauno and unassigned ivanpauno May 8, 2020
@ivanpauno ivanpauno force-pushed the ivanpauno/fix-build-single-typesupport branch from 2b407df to 16207b7 Compare May 15, 2020 16:42
@ivanpauno
Copy link
Member Author

ivanpauno commented May 15, 2020 •
edited
Loading

Single typesupport builds:

  • Before Build Status
  • After Build Status

@ivanpauno
Copy link
Member Author

Multiple typesupports build:

  • Linux Build Status

@ivanpauno
Copy link
Member Author

@dirk-thomas PTAL

@ivanpauno ivanpauno mentioned this pull request May 20, 2020
Merged
@ivanpauno
Move headers to detail subdir (#40)
5f6f49f 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Use modern cmake to fix single typesupport builds (#40)
61f50ae 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/fix-build-single-typesupport branch from 4cd84a8 to 61f50ae Compare May 20, 2020 17:25
@ivanpauno ivanpauno changed the title Fix build with single typesupport Move headers under detail subfolder and use modern cmake to fix single typesupport builds May 20, 2020
jacobperron
jacobperron approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@ivanpauno
Copy link
Member Author

Job config:

build: --packages-up-to test_msgs
test: --packages-select rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp

Single typesupport builds:

  • Before Build Status
  • After Build Status

Multiple typesupport builds:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit f8c9602 into master May 20, 2020
ivanpauno added a commit that referenced this pull request May 20, 2020
@ivanpauno
Move headers to detail subdir (#40)
0434c59 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-build-single-typesupport branch May 20, 2020 21:19
@tfoote tfoote mentioned this pull request May 22, 2020
Closed
ivanpauno added a commit that referenced this pull request May 26, 2020
@ivanpauno
Revert "Use modern cmake to fix single typesupport builds (#40)"
9d32893 
This reverts commit f8c9602.
ivanpauno added a commit that referenced this pull request May 26, 2020
@ivanpauno
Revert "Use modern cmake to fix single typesupport builds (#40)"
7c29a86 
This reverts commit f8c9602.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno mentioned this pull request May 26, 2020
Merged
ivanpauno added a commit that referenced this pull request May 26, 2020
@ivanpauno
Revert "Use modern cmake to fix single typesupport builds (#40)" (#47)
5b67d83 
This reverts commit f8c9602.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic left review comments

@jacobperron jacobperron jacobperron approved these changes

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivanpauno @dirk-thomas @jacobperron @hidmic