Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable suffix in rosidl_export_typesupport_targets #483

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix variable suffix in rosidl_export_typesupport_targets #483

merged 1 commit into from
May 20, 2020

Conversation

ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented May 8, 2020 •
edited
Loading

_suffix wasn't being set here:

rosidl/rosidl_cmake/cmake/rosidl_cmake_export_typesupport_targets-extras.cmake.in

Line 15 in f3f639d

list(APPEND @PROJECT_NAME@_TARGETS${_suffix} "${_target}")

This PR fixes that.

@ivanpauno ivanpauno mentioned this pull request May 8, 2020
Merged
@ivanpauno ivanpauno force-pushed the ivanpauno/fix-build-single-typesupport branch from 1eba314 to e46837a Compare May 8, 2020 17:43
@ivanpauno ivanpauno self-assigned this May 14, 2020
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label May 14, 2020
@ivanpauno
Fix variable suffix in rosidl_export_typesupport_targets
d42b392 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/fix-build-single-typesupport branch from e46837a to d42b392 Compare May 15, 2020 16:43
jacobperron
jacobperron approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can live with the API break since it seems contained to this repository and is new API in Foxy; so we're not likely to impact many users.

@ivanpauno ivanpauno changed the title Fix build single typesupport Fix rosidl_export_typesupport_targets behavior May 20, 2020
@ivanpauno
Copy link
Member Author

CI config (testing only this PR, not including ros2/rosidl_typesupport_fastrtps#40):

  • build: --packages-up-to test_msgs
  • test: --packages-select rosidl_cmake

Jobs:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno changed the title Fix rosidl_export_typesupport_targets behavior Fix variable suffix in rosidl_export_typesupport_targets May 20, 2020
@ivanpauno ivanpauno merged commit 29e50d2 into master May 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/fix-build-single-typesupport branch May 20, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@jacobperron jacobperron jacobperron approved these changes

@hidmic hidmic Awaiting requested review from hidmic

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivanpauno @jacobperron @dirk-thomas @hidmic