Add tests for wstring conversion routines #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cottsay
commented
May 19, 2020
cottsay
commented
- Linux
- Linux-aarch64
- macOS
- Windows
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
enhancement
ahcorde
approved these changes
May 19, 2020
brawner
reviewed
May 20, 2020
| // Force malloc/realloc to fail | ||
| auto on_unexpected_operation = | ||
| []() { | ||
| throw std::exception(); |
There was a problem hiding this comment.
If this throws the developer will get a backtrace so they can know whether it was line 41 or 42 yah?
There was a problem hiding this comment.
This isn't straightforward, but osrf_testing_tools_cpp::memory_tools will catch this exception, print an error message, and make the memory operation return nullptr. We should never see the backtrace.
|
|
||
| TEST(test_wstring_conversion, wstring_round_trip) | ||
| { | ||
| std::wstring wstring(L"¡Hola, Mundo!"); |
There was a problem hiding this comment.
Add tests for empty string, and default constructed string. Are there any other potential failure cases that would need to be checked?
There was a problem hiding this comment.
I can think of no more than what you mentioned. Added in 38986f0.
Signed-off-by: Scott K Logan <logans@cottsay.net>
|
Fresh CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.