Fix some comparisons with a sign mismatch (#32)

Signed-off-by: Scott K Logan <logans@cottsay.net>
ros2 · Jun 24, 2019 · f430a91 · f430a91
1 parent 8b0a298
commit f430a91
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rosidl_typesupport_opensplice_c/resource/msg__type_support_c.cpp.em b/rosidl_typesupport_opensplice_c/resource/msg__type_support_c.cpp.em
@@ -204,7 +204,7 @@ convert_ros_to_dds_@(__ros_msg_type_prefix)(const void * untyped_ros_message, vo
     size_t size = @(member.type.size);
 @[    else]@
     size_t size = ros_message->@(member.name).size;
-    if (size > (std::numeric_limits<DDS::Long>::max)()) {
+    if (size > static_cast<size_t>((std::numeric_limits<DDS::Long>::max)())) {
       return "array size exceeds maximum DDS sequence size";
     }
     DDS::Long length = static_cast<DDS::Long>(size);

diff --git a/rosidl_typesupport_opensplice_cpp/resource/msg__type_support.cpp.em b/rosidl_typesupport_opensplice_cpp/resource/msg__type_support.cpp.em
@@ -148,7 +148,7 @@ convert_ros_message_to_dds(
     size_t size = @(member.type.size);
 @[    else]@
     size_t size = ros_message.@(member.name).size();
-    if (size > (std::numeric_limits<DDS::Long>::max)()) {
+    if (size > static_cast<size_t>((std::numeric_limits<DDS::Long>::max)())) {
       throw std::runtime_error("array size exceeds maximum DDS sequence size");
     }
     DDS::Long length = static_cast<DDS::Long>(size);