Skip to content

Commit

Permalink
Migrate marker display (#229)
Browse files Browse the repository at this point in the history
* Move marker_display

* Make Markers compile and lint

* Make MarkerDisplay compile and work

- Fix QueueSizeProperty in MarkerDisplay
- Fix MarkerArray subscription

* Add MarkerDisplay to plugin_description.xml

* Extract interface from frame_manager to make it mockable.

* Move frame_manager.hpp from include to src.

* Create mock class for FrameManager

* Don't render markers when transform is missing

* Reorder cleanup to prevent segmentation faults

Delete render_panel after visualization manager since the display cleanup in the visualization manager requires an existing render_panel

* Split triangle list marker into multiple methods

* Refactor (minor) marker_base

* Expose constructor necessary for testing MarkerDisplay

* Refactor ShapeMarker

* Minor refactoring of text_view_facing_marker

* Fix test in mesh_resource_marker

* Refactoring of mesh_resource_marker

* Remove duplicate code

* Add tests for MarkerDisplay

* Refactor MarkerDisplay

* Extract error printing in triangle list marker

* Refactoring of tests to only use one test target

* Reset position of arrow to 0, if previously was set from points

* Setup marker tests

* Refactoring of PointsMarker

* Extract common functionality from line_markers and refactoring

* Refactoring of ArrowMarker

* Disable tests for now

* Fix FrameManager include in PoseDisplay

* Add visualization_msgs to package.xml
  • Loading branch information
Martin-Idel-SI authored and wjwwood committed Mar 17, 2018
1 parent 8dfb0c0 commit 2398b50
Show file tree
Hide file tree
Showing 86 changed files with 5,729 additions and 2,586 deletions.
543 changes: 0 additions & 543 deletions rviz/src/rviz/default_plugin/marker_display.cpp

This file was deleted.

194 changes: 0 additions & 194 deletions rviz/src/rviz/default_plugin/marker_display.h

This file was deleted.

161 changes: 0 additions & 161 deletions rviz/src/rviz/default_plugin/markers/arrow_marker.cpp

This file was deleted.

Loading

0 comments on commit 2398b50

Please sign in to comment.