Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize more of the visualization_manager members. #1090

Merged
merged 1 commit into from Nov 16, 2023
Merged

Initialize more of the visualization_manager members. #1090

merged 1 commit into from Nov 16, 2023

Conversation

clalancette
Copy link
Contributor

This is so we don't access uninitialized memory during startup.

I came across this while running rviz2 under valgrind.

@clalancette
Initialize more of the visualization_manager members.
dd1bdef 
This is so we don't access uninitialized memory during
startup.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 51e576c into rolling Nov 16, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-startup-ub branch November 16, 2023 08:48
@ahcorde
Copy link
Contributor

ahcorde commented Nov 16, 2023

https://github.com/Mergifyio backport humble iron

@mergify Mergify
Copy link

mergify bot commented Nov 16, 2023 •
edited

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@clalancette @mergify
Initialize more of the visualization_manager members. (#1090)
40a916b 
This is so we don't access uninitialized memory during
startup.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 51e576c)
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@clalancette @mergify
Initialize more of the visualization_manager members. (#1090)
be838ac 
This is so we don't access uninitialized memory during
startup.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 51e576c)
This was referenced Nov 16, 2023
Merged
Merged
ahcorde pushed a commit that referenced this pull request Nov 16, 2023
@mergify @clalancette
Initialize more of the visualization_manager members. (#1090) (#1092)
35eb77d 
This is so we don't access uninitialized memory during
startup.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 51e576c)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 16, 2023
@mergify @clalancette
Initialize more of the visualization_manager members. (#1090) (#1091)
33037d1 
This is so we don't access uninitialized memory during
startup.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 51e576c)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clalancette @ahcorde