Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RViz does not run in Debug mode on Mac #246

Closed
Martin-Idel-SI opened this issue Apr 16, 2018 · 3 comments · Fixed by #258
Closed

RViz does not run in Debug mode on Mac #246

Martin-Idel-SI opened this issue Apr 16, 2018 · 3 comments · Fixed by #258
Labels
bug Something isn't working waiting on upstream waiting on a change in an upstream dependency

Comments

@Martin-Idel-SI
Copy link
Contributor

A debug build on OSX segfaults at startup with an assert failing in Ogre:

Assertion failed: ([externalHandle isKindOfClass:[NSView class]]), function create, file /Users/osrf/jenkins-agent/workspace/nightly_osx_debug/ws/build/rviz_ogre_vendor/ogre-master-ca665a6-prefix/src/ogre-master-ca665a6/RenderSystems/GLSupport/src/OSX/OgreOSXCocoaWindow.mm, line 334.

This is an issue of the Ogre integration on Mac, which we thought had been solved (and actually seems to be solved in Release and ReleaseWithDebug mode), but still persists in Debug mode.

This also results in the CI-failures discussed in #245.
@Martin-Idel-SI Martin-Idel-SI mentioned this issue Apr 16, 2018
Closed
nuclearsandwich added a commit to nuclearsandwich/rviz that referenced this issue Apr 25, 2018
@nuclearsandwich
Disable rendering tests on Mac when building debug.
72ea96e 
Display tests currently fail due to ros2#246.
In order to make it easier to triage CI failures, disable these tests
in that configuration pending resolution of the failure.
@nuclearsandwich nuclearsandwich mentioned this issue Apr 25, 2018
Merged
@Martin-Idel-SI Martin-Idel-SI mentioned this issue Apr 26, 2018
Closed
@Martin-Idel-SI
Copy link
Contributor Author

Martin-Idel-SI commented Apr 26, 2018 •
edited
Loading

We tracked the problem to an issue with Ogre's render system (no Qt or rviz involved) and added an issue upstream (OGRECave/ogre#745). Till the issue is solved there, I guess there is not much more we can do at the moment.

@wjwwood
Copy link
Member

wjwwood commented Apr 26, 2018

Thanks @Martin-Idel-SI for looking into it and opening the issue.

@wjwwood wjwwood added bug Something isn't working waiting on upstream waiting on a change in an upstream dependency labels Apr 26, 2018
nuclearsandwich added a commit that referenced this issue Apr 27, 2018
@nuclearsandwich
Disable rendering tests on Mac when building debug. (#257)
e8181a4 
* Disable rendering tests on Mac when building debug.

Display tests currently fail due to #246.
In order to make it easier to triage CI failures, disable these tests
in that configuration pending resolution of the failure.
@botteroa-si botteroa-si mentioned this issue May 8, 2018
Merged
@Martin-Idel-SI
Copy link
Contributor Author

I had a nice conversation with the Ogre maintainer and it turns out that the issue must be on our side. I'm still confused as to why it works in Release mode, but apparently, we just hand in a correct externalWindowHandle later on and everything just works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waiting on upstream waiting on a change in an upstream dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix debug build on Mac bosch-io/rviz
2 participants
@wjwwood @Martin-Idel-SI