Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate odometry display #275

Merged
merged 21 commits into from
Jun 14, 2018
Merged

Migrate odometry display #275

merged 21 commits into from
Jun 14, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented May 30, 2018 •
edited
Loading

Closes #80

  • also ports covariance visual and covariance property as it is used in odometry display
  • makes covariance property and visual work like other visuals and properties
  • further improve Visual Testing Framework: can now easily search for subproperties

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Martin-Idel-SI
Copy link
Contributor Author

I have no idea why this always fails - it's not rviz. I updated my ros2.repos file, but that's apparently not it.

@mikaelarguedas
Copy link
Member

It looks like the repos file used in the CI above is not exactly up to date, as it doesnt contain: ros2/ros2#491. That's why CI is failing complaining about a missing libyaml_vendor package

--- stderr: rcl_yaml_param_parser
00:07:40.622 CMake Error at CMakeLists.txt:8 (find_package):
00:07:40.622   By not providing "Findlibyaml_vendor.cmake" in CMAKE_MODULE_PATH this
00:07:40.622   project has asked CMake to find a package configuration file provided by
00:07:40.622   "libyaml_vendor", but CMake did not find one.
00:07:40.622 
00:07:40.622   Could not find a package configuration file provided by "libyaml_vendor"
00:07:40.622   with any of the following names:
00:07:40.622 
00:07:40.622     libyaml_vendorConfig.cmake
00:07:40.622     libyaml_vendor-config.cmake
00:07:40.622 
00:07:40.622   Add the installation prefix of "libyaml_vendor" to CMAKE_PREFIX_PATH or set
00:07:40.622   "libyaml_vendor_DIR" to a directory containing one of the above files.  If
00:07:40.623   "libyaml_vendor" provides a separate development package or SDK, be sure it
00:07:40.623   has been installed.
00:07:40.623 
00:07:40.623 
00:07:40.623 ---

@Martin-Idel-SI
Copy link
Contributor Author

Martin-Idel-SI commented Jun 4, 2018 •
edited
Loading

Weird, because I did update it just today... I guess I must've forgotten to enter the new URL before rebuilding... Thanks for looking into this!

Here's hopefully better CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jun 6, 2018
@wjwwood wjwwood added this to the bouncy milestone Jun 6, 2018
@botteroa-si botteroa-si force-pushed the feature/migrate_odometry_display branch from 6db5d18 to 162d412 Compare June 12, 2018 13:06
Martin-Idel-SI and others added 21 commits June 13, 2018 12:13
@Martin-Idel-SI @botteroa-si
Move odometry display and covariance classes
41503fa
@Martin-Idel-SI @botteroa-si
Make everything compile and fix linters
38617ad
@Martin-Idel-SI @botteroa-si
Move covariance_visual to rviz_rendering
cb0e6d3 
- covariance_property is no friend class anymore
- make covariance_visual independent of geometry_msgs
@Martin-Idel-SI @botteroa-si
Add to plugins_descriptions.xml file
18cfac6
@botteroa-si
Remove Eigen dependency in rviz_default_plugins
74c3a2d
@Martin-Idel-SI @botteroa-si
Minor refactoring of CovarianceProperty
e87c927
@Martin-Idel-SI @botteroa-si
Add tests to odometry_display
9df70f0
@Martin-Idel-SI @botteroa-si
Extract quaternion helper and include a test
b860155
@anhosi @botteroa-si
Add rudimentary tests for CovarianceVisual
229f62b
@botteroa-si
Move scene graph introspection to rviz_rendering
21dadf2 
- Split scene_graph_introspection into gmock dependent/independent part
- add helpers methods to find rviz shapes
- polish methods to make them available throughout RViz
@Martin-Idel-SI @botteroa-si
Add possibility to change arbitrary subproperties to testing framework
a2a6b10
@Martin-Idel-SI @botteroa-si
Add visual test for odometry display
d47610e
@anhosi @botteroa-si
Refactoring of CovarianceVisual
3608fde
@botteroa-si
Add further tests for odometry_display
031b9df
@botteroa-si
Refactoring of odometry_display.cpp
69a2851
@Martin-Idel-SI @botteroa-si
Make covariances behave like other RViz objects
28be16f 
- The property is now only a container for GUI interaction
- Covariance visuals need to be kept in the display
- Allow simple setting of property content for every visual
- Make CovarianceVisual independent of rviz_rendering::Object since there is no relation anymore (not all objects derive from Object anyway)
@botteroa-si
Set error status if tansform fails
88260e9
@botteroa-si
Fix tests after rebase
b12bf0c
@botteroa-si
Move odometry_display.hpp to include folder
3c490a2
@botteroa-si
Fix tests after rebase
f191007
@botteroa-si
Harmonize failed transfor error status
ae4fad1
@botteroa-si botteroa-si force-pushed the feature/migrate_odometry_display branch from 162d412 to ae4fad1 Compare June 13, 2018 13:47
@botteroa-si
Copy link
Contributor

New CI after rebase:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

wjwwood
wjwwood approved these changes Jun 14, 2018
View reviewed changes
rviz_visual_testing_framework/src/page_objects/base_page_object.cpp
getMainPropertyIndex(main_property_name, property_row_index, relative_display_index) :
getSubPropertyIndex(
sub_property_name, property_row_index, sub_property_index, relative_display_index);
[this, value_to_set, property_to_change, super_properties{std::move(super_properties)}] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this use of initializer list within a lambda capture statement. 🆒

@wjwwood wjwwood merged commit 4cbab09 into ros2:ros2 Jun 14, 2018
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@anhosi anhosi deleted the feature/migrate_odometry_display branch June 14, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
bouncy
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Martin-Idel-SI @mikaelarguedas @botteroa-si @wjwwood @clalancette @anhosi