Migrate GridCellsDisplay #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI:
|
botteroa-si
force-pushed
the
feature/migrate_grid_cells_display
branch
from
3182571
to
9c80303
Compare
|
New CI after rebase:
|
wjwwood
approved these changes
Jun 14, 2018
| /** | ||
| * \class GridCellsDisplay | ||
| * \brief Displays a nav_msgs::GridCells message | ||
| */ | ||
| class GridCellsDisplay : public Display | ||
| class RVIZ_DEFAULT_PLUGINS_PUBLIC GridCellsDisplay : public | ||
| rviz_common::RosTopicDisplay<nav_msgs::msg::GridCells> |
There was a problem hiding this comment.
This is really strange, but if that's what uncrustify wants to do...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96.
This PR includes the migration and refactoring of the GridCellsDisplay, with the addition of tests for it and of a visual test.