Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement workaround for missing transform between identical frames #298

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Implement workaround for missing transform between identical frames #298

merged 1 commit into from
Jun 14, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jun 13, 2018 •
edited
Loading

CI upcoming

@Martin-Idel-SI
Implement workaround for missing transform from frame to frame
cba1ad9 
- make grid invisible when transform is missing
@wjwwood wjwwood added the in review Waiting for review (Kanban column) label Jun 13, 2018
@Martin-Idel-SI
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood assigned wjwwood and unassigned wjwwood Jun 13, 2018
@wjwwood wjwwood merged commit 86b9cea into ros2:ros2 Jun 14, 2018
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@anhosi anhosi deleted the bugfix/fix_missing_identity_transform branch June 14, 2018 06:15
@Martin-Idel-SI Martin-Idel-SI mentioned this pull request Jun 14, 2018
Closed
@botteroa-si botteroa-si mentioned this pull request Jun 14, 2018
Merged
greimela-si pushed a commit to bosch-io/rviz that referenced this pull request Jul 30, 2018
@botteroa-si @greimela-si
Revert workaround for identity transform after geometry2 fix
a2579d8 
The workaround was introduced in PR ros2#298 and is now fixed
directly in geometry2
@greimela-si greimela-si mentioned this pull request Jul 30, 2018
Merged
wjwwood pushed a commit that referenced this pull request Aug 2, 2018
@greimela-si @wjwwood
Revert workaround for identity transform after geometry2 fix (#343)
1f9a3ea 
The workaround was introduced in PR #298 and is now fixed
directly in geometry2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Martin-Idel-SI @wjwwood @clalancette