[Windows][ros2] Constraint Freetype dependencies for more predictable build result. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clalancette any feedback on this? |
|
cc @jacobperron this is ready for review and merge. And hope this can be back ported to |
jacobperron
approved these changes
Oct 25, 2019
|
Dashing backport: #489 |
jacobperron
added a commit
that referenced
this pull request
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick for #393.
This
freetypelibrary in ROS2 on Windows is a static library and that implies any dependencies offreetypealso need to be exported to the downstream project which consumesfreetype.If following the steps from
https://index.ros.org/doc/ros2/Installation/Windows-Development-Setup/, there is no problem because no other unexpected libraries in CMAKE search path. However, for example,ZLibjust happens to be in the CMAKE search path, thenfreetypewill be intellegently try to discover and link againstZLiband however the freetype CMake config was not exposing its dependencies to the downstream projects consumingfreetype.In order to make the build more predictable for different environment, I added the flags to explicitly disable all the optional dependencies discovery.
UPDATED: Here is a example of the build error when running into this.