mojave compatibility #414
Merged
mojave compatibility #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
|
bumping this back up. CI:
|
|
CI seems to be working well now, again:
|
jacobperron
approved these changes
Jul 11, 2019
Karsten1987
added a commit
that referenced
this pull request
Jul 31, 2019
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
added a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having trouble compiling the
rviz_visual_testing_framework. For this I tried to compile rviz with--cmake-args -DBUILD_TESTING=OFFand saw that the rviz testing framework is still required to be built.Secondly, while digging into why OGRE would fail, I've noticed that the Java components are failing and I started to wonder why they are built in the first place. So I've disabled the Python and Java components, which additionally speeds up the process.
Signed-off-by: Karsten Knese karsten@openrobotics.org