Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camera info for camera display #419

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Fix camera info for camera display #419

merged 2 commits into from
Jan 20, 2020

Conversation

chapulina
Copy link
Contributor

A quick and dirty solution to #207 .

You can try it out with Gazebo:

  1. Launch Gazebo with the camera demo world

     gazebo gazebo_ros_camera_demo.world

  2. Launch RViz with this config

  3. Publish a marker with:

     ros2 topic pub -1 /visualization_marker visualization_msgs/msg/Marker '{header: {frame_id: "camera_link"}, id: 1, type: 1, action: 0, pose: {position: {z: 2}, orientation: {y: 0.38, w: 0.92}}, scale: {x: 1., y: 1., z: 1.}, color: {r: 1., g: 0., b: 1., a: 1.}}'

On RViz, the marker should be correctly projected onto the camera image:

camera_info_rviz

@chapulina chapulina mentioned this pull request Jun 27, 2019
Merged
@chapulina chapulina added this to Proposed in Dashing Patch Release 2 via automation Jul 11, 2019
@chapulina chapulina mentioned this pull request Jul 25, 2019
Closed
@nuclearsandwich nuclearsandwich removed this from Proposed in Dashing Patch Release 2 Aug 1, 2019
@nuclearsandwich nuclearsandwich added this to Proposed in Dashing Patch Release 3 via automation Aug 1, 2019
@nuclearsandwich nuclearsandwich removed this from Proposed in Dashing Patch Release 3 Sep 6, 2019
mjcarroll
mjcarroll approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some merge conflicts atm.

@nuclearsandwich nuclearsandwich removed this from Proposed in Dashing Patch Release 4 Oct 16, 2019
@chapulina
Copy link
Contributor Author

Rebased 😉

mjcarroll
mjcarroll approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@mjcarroll
Copy link
Member

Ah, but there are a few uncrustify failures

@ahcorde
Copy link
Contributor

ahcorde commented Nov 27, 2019

Sorry for jumping here, fixing uncrustify

@nuclearsandwich nuclearsandwich removed this from Proposed in Dashing Patch Release 5 Dec 6, 2019
@mjcarroll mjcarroll added this to Needs Backport in Eloquent Patch Release 1 Jan 17, 2020
@mjcarroll mjcarroll added this to Needs Backport in Eloquent Patch Release 2 Jan 17, 2020
@mjcarroll mjcarroll removed this from Needs Backport in Eloquent Patch Release 1 Jan 17, 2020
@ahcorde ahcorde merged commit b625e1f into ros2 Jan 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the camera_info branch January 20, 2020 07:31
ahcorde added a commit that referenced this pull request Jan 20, 2020
@chapulina @ahcorde
Fix camera info for camera display (#419)
afd3826 
* Fix camera info for camera display

* rviz_default_plugins: fixed uncrustify

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Jan 20, 2020
Merged
ahcorde added a commit that referenced this pull request Jan 21, 2020
@ahcorde @chapulina
Fix camera info for camera display (#419) (#500)
a396a03 
* Fix camera info for camera display

* rviz_default_plugins: fixed uncrustify

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

Co-authored-by: chapulina <louise@openrobotics.org>
@nuclearsandwich
Copy link
Member

@ahcorde since you opened the Eloquent backport do you want to try and do likewise for Dashing?

@nuclearsandwich nuclearsandwich moved this from Proposed to To Do in Dashing Patch Release 6 Mar 5, 2020
ahcorde added a commit that referenced this pull request Mar 6, 2020
@chapulina @ahcorde
Fix camera info for camera display (#419)
4f6b625 
* Fix camera info for camera display

* rviz_default_plugins: fixed uncrustify

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Mar 6, 2020
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Mar 6, 2020

Sure @nuclearsandwich

PR: #516

ahcorde added a commit that referenced this pull request Mar 11, 2020
@ahcorde @chapulina
Fix camera info for camera display (#419) (#516)
d7cd04c 
* Fix camera info for camera display

* rviz_default_plugins: fixed uncrustify

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

Co-authored-by: chapulina <louise@openrobotics.org>
@mjcarroll mjcarroll moved this from Needs Backport to Released in Eloquent Patch Release 2 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dashing Patch Release 6
To Do
Eloquent Patch Release 2
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chapulina @mjcarroll @ahcorde @nuclearsandwich