Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Interaction Tool #423

Merged
merged 15 commits into from
Aug 21, 2019
Merged

Migrate Interaction Tool #423

merged 15 commits into from
Aug 21, 2019

Conversation

jacobperron
Copy link
Member

Resolves #221

@jacobperron
Move InteractionTool source files
c101295 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Get interaction tool compiling + lint
eb2edfc 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix warning
11b38a3 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix lint errors
5bc06a4 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add InteractionTool plugin description
457bae2 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add InteractionTool to default.rviz
23735d9 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Minor refactor
392cde9 
* Use smart pointer
* const variables where possible

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update README
bc79590 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added this to In progress in Eloquent via automation Jul 8, 2019
@jacobperron
Add missing include
685a307 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Refactor processMouseEvent into smaller methods
5a5337c 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the in review Waiting for review (Kanban column) label Jul 13, 2019
@jacobperron jacobperron requested a review from wjwwood July 24, 2019 16:14
Eloquent automation moved this from In progress to Reviewer approved Jul 24, 2019
wjwwood
wjwwood approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I didn't test it locally.

rviz_common/include/rviz_common/render_panel.hpp Outdated Show resolved Hide resolved
rviz_common/src/rviz_common/render_panel.cpp Outdated Show resolved Hide resolved
rviz_default_plugins/include/rviz_default_plugins/tools/interaction/interaction_tool.hpp Outdated Show resolved Hide resolved
@jacobperron
Use selection type "Replace" instead of "Add"
3d576b8 
Otherwise, interactive objects are never deselected as the mouse moves around.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Address review
69ee286 
Remove TODOs and change doxygen style.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Enable the interaction tool by default
7a97fe0 
This is the same as RViz for ROS 1.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add missing override keyword
cf6d449 
Resolves Clang warnings.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

With cf6d449

  • macOS Build Status

@jacobperron
Fix cpplint
e67762e 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

FIx lint test: Build Status

@jacobperron jacobperron merged commit d873784 into ros2 Aug 21, 2019
Eloquent automation moved this from Reviewer approved to Done Aug 21, 2019
@jacobperron jacobperron deleted the jacob/interaction_tool branch August 21, 2019 20:24
@jacobperron jacobperron mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martin-Idel Martin-Idel Martin-Idel left review comments

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
in review Waiting for review (Kanban column)
Projects
No open projects
Eloquent
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Interact tool
3 participants
@jacobperron @wjwwood @Martin-Idel