Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Interaction Tool #423

Merged
merged 15 commits into from
Aug 21, 2019
Merged
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ For some displays, the [documentation is updated](docs/FEATURES.md).
| Illuminance | 2D Nav Goal | Top Down Orthographic | Views |
| Image | Publish Point |
| Laser Scan | Initial Pose |
| Map |
| Marker |
| Map | Interact |
| Marker |
| Marker Array |
| Odometry |
| Point Cloud (1 and 2) |
Expand All @@ -43,7 +43,7 @@ These features have not been ported to `ros2/rviz` yet.

| Displays | Tools | Panels |
| -------------------- | ------------ | ------ |
| Axes | Interact | Time |
| Axes | | Time |
| DepthCloud |
| Effort |
| Interactive Marker |
Expand Down
201 changes: 0 additions & 201 deletions rviz/src/rviz/default_plugin/tools/interaction_tool.cpp

This file was deleted.

86 changes: 0 additions & 86 deletions rviz/src/rviz/default_plugin/tools/interaction_tool.h

This file was deleted.

5 changes: 2 additions & 3 deletions rviz_common/default.rviz
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ Visualization Manager:
Fixed Frame: /map
Name: root
Tools:
# TODO(wjwwood): restore these tools when ported
# - Class: rviz/Interact
# Hide Inactive Objects: true
- Class: rviz_default_plugins/Interact
Hide Inactive Objects: true
- Class: rviz_default_plugins/MoveCamera
- Class: rviz_default_plugins/Select
- Class: rviz_default_plugins/FocusCamera
Expand Down
5 changes: 1 addition & 4 deletions rviz_common/include/rviz_common/render_panel.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ class RVIZ_COMMON_PUBLIC RenderPanel : public QWidget

static const Ogre::Vector3 default_camera_pose_;

// TODO(wjwwood): reenable these and pass down to rviz_rendering::RenderWindow
#if 0
/// Show the given menu as a context menu, positioned based on the current mouse position.
/**
* This can be called from any thread.
Expand All @@ -114,7 +112,6 @@ class RVIZ_COMMON_PUBLIC RenderPanel : public QWidget

/// Return true if the context menu for this panel is visible.
bool contextMenuVisible();
#endif

// TODO(wjwwood): this should be moved into rviz_rendering::RenderWindowImpl, I think
// virtual void sceneManagerDestroyed(Ogre::SceneManager * source);
Expand Down Expand Up @@ -177,7 +174,7 @@ class RVIZ_COMMON_PUBLIC RenderPanel : public QWidget

private Q_SLOTS:
void sendMouseMoveEvent();
// void onContextMenuHide();
void onContextMenuHide();

private:
QTimer * fake_mouse_move_event_timer_;
Expand Down
2 changes: 0 additions & 2 deletions rviz_common/src/rviz_common/render_panel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ void RenderPanel::resizeEvent(QResizeEvent * event)

const Ogre::Vector3 RenderPanel::default_camera_pose_ = Ogre::Vector3(999999, 999999, 999999);

#if 0
void RenderPanel::showContextMenu(std::shared_ptr<QMenu> menu)
{
std::lock_guard<std::mutex> lock(context_menu_mutex_);
Expand All @@ -315,7 +314,6 @@ bool RenderPanel::contextMenuVisible()
{
return context_menu_visible_;
}
#endif

void RenderPanel::contextMenuEvent(QContextMenuEvent * event)
{
Expand Down
2 changes: 2 additions & 0 deletions rviz_default_plugins/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ set(rviz_default_plugins_headers_to_moc
include/rviz_default_plugins/robot/robot_element_base_class.hpp
include/rviz_default_plugins/tools/measure/measure_tool.hpp
include/rviz_default_plugins/tools/nav_goal/goal_tool.hpp
include/rviz_default_plugins/tools/interaction/interaction_tool.hpp
include/rviz_default_plugins/tools/pose/pose_tool.hpp
include/rviz_default_plugins/tools/pose_estimate/initial_pose_tool.hpp
include/rviz_default_plugins/tools/point/point_tool.hpp
Expand Down Expand Up @@ -186,6 +187,7 @@ set(rviz_default_plugins_source_files
src/rviz_default_plugins/robot/robot_link.cpp
src/rviz_default_plugins/robot/robot_element_base_class.cpp
src/rviz_default_plugins/robot/tf_link_updater.cpp
src/rviz_default_plugins/tools/interaction/interaction_tool.cpp
src/rviz_default_plugins/tools/measure/measure_tool.cpp
src/rviz_default_plugins/tools/focus/focus_tool.cpp
src/rviz_default_plugins/tools/move/move_tool.cpp
Expand Down
Loading