Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Axes Display #429

Merged
merged 8 commits into from
Oct 1, 2019
Merged

Migrate Axes Display #429

merged 8 commits into from
Oct 1, 2019

Conversation

Martin-Idel
Copy link
Contributor

Closes #93

  • Migrate display and fix linters
  • Add visual test for axes display.
  • Do not display axes when transformation fails
  • Small refactoring of axes class for c++14

@jacobperron jacobperron mentioned this pull request Sep 5, 2019
Merged
@jacobperron jacobperron self-requested a review September 9, 2019 23:19
jacobperron
jacobperron reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to get to this.

LGTM 👍 After a rebase I'll trigger CI.

rviz_default_plugins/plugins_description.xml Outdated Show resolved Hide resolved
@Martin-Idel
Copy link
Contributor Author

Rebase done.

I also took the liberty to tweak the readme: The "Oculus" display isn't part of this repository and the Interactive Marker display as well as message filters have been ported. On the other hand, stereo functionality is currently not enabled, so that should be put on the list.

I can revert those changes if you want to, of course.

@jacobperron
Copy link
Member

jacobperron commented Sep 30, 2019 •
edited
Loading

I noticed that with the default value, FIXED_FRAME, it is unable to resolve the transformation even if the global fixed frame is available. I guess this is an issue to be resolved in the frame transformer.
We can ticket it separately if you agree.

@jacobperron
Copy link
Member

jacobperron commented Sep 30, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: re-triggered with dbe74f6

@jacobperron
Use getFrameStd instead of getStdString
dbe74f6 
To ensure we get a frame ID in the case the property is set to the fixed frame.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@Martin-Idel
Copy link
Contributor Author

Thanks for catching this. I only retested with the visual test and some frame transformations. Looks good to me.

@jacobperron jacobperron merged commit a2be171 into ros2:ros2 Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate AxesDisplay
2 participants
@Martin-Idel @jacobperron