Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not select interactive markers when mousing over them #451

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

jacobperron
Copy link
Member

Follow-up from #423.

These changes remove an undesired selection of interactive markers when mousing over them. The selection was causing the markers to be highlighted with a bounding box.

  • Expose selection manager's "pick" method
    The method is useful for getting objects in a bounding box without actually selecting them.
    The last argument, single_render_pass, was not being used and so it has been removed.
  • Use pick method instead of select
    This removes a visual bounding box (highlight) appearing over interactive markers.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

The method is useful for getting objects in a bounding box without actually selecting them.
The last argument, single_render_pass, was not being used and so it has been removed.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This removes a visual bounding box (highlight) appearing over interactive markers.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron merged commit 564fa38 into ros2 Aug 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/fix_interact_visual branch August 22, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants