Rename 2d Nav Goal to 2d Goal Pose + move_base_simple to goal_pose

[SteveMacenski]

Per #444

Move base isn't the used tool for ROS2 navigation, and removing nav from the title makes it a more general waypoint dropping tool.

[SteveMacenski]

I'm not entirely clear if this is necessary, but defensively removed anything "Nav Goal" related

[SteveMacenski]

@jacobperron following up on it. I have a Nav2 PR to match ros-navigation/navigation2#1071

[jacobperron]

cpplint is complaining about the headers guards in goal_tool.hpp:

#ifndef header guard has wrong style, please use: RVIZ_DEFAULT_PLUGINS__TOOLS__GOAL_POSE__GOAL_TOOL_HPP_

Otherwise, LGTM!

[SteveMacenski]

Will fix.

[jacobperron]

• Linux
• Linux-aarch64
• macOS
• Windows

[jacobperron]

Thanks for the contribution!

[wjwwood]

Hey guys, I just noticed this touched files in the rviz folder, but that's just legacy. In the future please try to avoid that unless you're migrating code out of the rviz folder into one of the new packages. Hopefully the rviz folder should eventually evaporate once everything is ported.

[SteveMacenski]

Thanks for the heads up @wjwwood. What are the big elements left to port? Is there a migration ticket?

[jacobperron]

@wjwwood Oops, my bad. I misread the file paths as starting with the name of the repo 🙃

@SteveMacenski You can find a list of things left to port in the README. There are also PRs open for a couple of them (e.g. #429 and #457).

[SteveMacenski]

@jacobperron what's the blocker on #429 ? its been sitting around for awhile

[jacobperron]

@jacobperron what's the blocker on #429 ? its been sitting around for awhile

I'm not sure there's any blocker. We just haven't gotten around to reviewing it.
I can try and make some time.

[SteveMacenski]

Oh no pressure from me, I was just wondering if there were some actions I could help with to move it along if there was something to be done