change default goal to goal_pose and not just in default rviz #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#455 updated the tool name, registration, default rviz files and documentation.
However the migration guide for Eloquent isn't technically correct (https://index.ros.org/doc/ros2/Releases/Release-Eloquent-Elusor/#rviz). The tool name changed, true, and the topic was changed for the default.rviz file. This is also where
/move_base_simple/goal
was defined fromgoal
. There never was/move_base_simple/goal
in the rviz tool file.If this is what we're going to say in the migration guide, we should change the actual default hardcoded in the tool to be
goal_pose
, rather than just a configuration change in therviz
file.I tried to think of a way to explain this better for the migration guide and decided that its just easier to align with it. If that's what people walked away thinking that PR did exactly, I should follow that.