Installed RViz configs for visual tests #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Dec 10, 2019
There was a problem hiding this comment.
I don't know if you noticed, but there's another PR open trying to resolve the same ticket (#379). Unfortunately, it looks like it's gone stale. In any case, I think it's fine if we continue with this one to resolve the ticket.
In addition to my comments below, there some linter errors being reported in the PR job.
rviz_visual_testing_framework/include/rviz_visual_testing_framework/visual_test_fixture.hpp
Outdated
Show resolved
Hide resolved
|
thanks for your comments @jacobperron |
jacobperron
reviewed
Jan 7, 2020
|
|
@ahcorde Could you also open a PR cherry-picking the change to the |
ahcorde
added a commit
that referenced
this pull request
Jan 10, 2020
* Installed RViz configs for visual tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installed RViz configs for visual tests
Add your description here
Related to this issue #372