Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rviz_rendering] Unnecessary information in ogre log messages #62

Closed
greimela-si opened this issue Oct 4, 2017 · 1 comment · Fixed by #123
Closed

[rviz_rendering] Unnecessary information in ogre log messages #62

greimela-si opened this issue Oct 4, 2017 · 1 comment · Fixed by #123
Assignees

Comments

@greimela-si
Copy link
Contributor

Ogre logs are redirected using rviz_rendering::ogre_rendering.cpp.

Currently, every log output generated by this class also includes the path to the ogre_rendering.cpp class.
Example:

[rviz_common:info] Creating resource group General, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
[rviz_common:info] Creating resource group OgreInternal, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
[rviz_common:info] Creating resource group OgreAutodetect, at /home/greimela/projects/ros2/rviz2_ws/src/aos-rviz2-public/rviz_rendering/src/rviz_rendering/ogre_logging.cpp:80
...

As far as I can tell Ogre does not provide information such as file name or line number in the Ogre::LogListener.
So we should just remove the path from the log message in this case.

@wjwwood
Copy link
Member

wjwwood commented Oct 20, 2017

Yeah, unfortunately the logging API I setup doesn't allow you to not specify the file and line number. I don't think we want to just exclude it because other instances of the log messages have meaningful files and line numbers in them, it's only the Ogre ones that don't and the ogre log messages which are being piped through this API don't provide the original file and line number.

@wjwwood wjwwood self-assigned this Nov 27, 2017
@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Nov 27, 2017
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants