-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pluginlib to reenable displays panel and load basic plugins #123
Conversation
Nice work! I built the branch on Ubuntu 16.04, here are some findings:
|
I updated the OP with more todo check boxes based on your feedback. I'm going to try and get this done today, but I have some things to do this afternoon which might get in the way of that. |
c74f6ca
to
8a86b00
Compare
Maybe we could take up these three fixes and tests for next week, @greimela-si and @wjwwood? So they would not be part of this PR:
|
@jeising that's the plan, but currently I'm hung up on an issue with the Qt Automoc step, but only on windows. I've spent the better part of a day on this one thing and haven't found a workaround just yet. I wanted it to be at least compiling before pushing this for merge (and then subsequently opening issues for the other problems). I'll push what I have shortly and describe the problem before picking up on it again. |
43cea0b
to
2a8db52
Compare
Some more findings:
On Ubuntu:
On Windows:
|
I fixed the orbit view controller in #129. |
This was done to avoid needing to make the header pluginlib_factory.hpp public in rviz_common.
This commit should be removed later. I had to do it for now to try and make progress on Windows.
7ef3a7c
to
24d506a
Compare
License question was resolved in ros-visualization/rviz#1147.
This pr does a bunch of stuff:
rviz_default_plugins
packageros2
branch forpluginlib
:SHARED
and changed other linking settings to address issue with multiple Ogre instances due to multiple copies of the Ogre static librariesrviz_default_plugins
What I still need to do:
This still doesn't get a display panel to show at first, that needs the configuration loading to be fixed, but you can add one from the add panel dialog.
I also need to test out the add display by topic more, since I just ported it without trying it out (just made it compile).