Fix possible nullptr access in robot_joint.cpp. #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by clang static analysis, the checks here are not sufficient to prevent a nullptr access in the unlikely case that a link is nullptr. Revamp the code so that we get out early if a link is nullptr. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjeronimo
approved these changes
Dec 17, 2020
Good point. I'll open up an issue to follow-up on this. Also, here is CI:
|
|
CI is green, so merging. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by clang static analysis, the checks here
are not sufficient to prevent a nullptr access in the
unlikely case that a link is nullptr. Revamp the code
so that we get out early if a link is nullptr.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org