Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated code RobotJoint #702

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Duplicated code RobotJoint #702

merged 3 commits into from
Jun 24, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 8, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

Related with this issue #637

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jun 8, 2021
@ahcorde ahcorde self-assigned this Jun 8, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@mjeronimo mjeronimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple occurrences where I'd recommend initializing all three of the output variables.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjeronimo June 24, 2021 11:19
@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 24, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit dcbe488 into galactic Jun 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/refactor/robot_joint branch June 24, 2021 20:53
ahcorde added a commit that referenced this pull request Jun 29, 2021
* Duplicated code RobotJoint

Signed-off-by: ahcorde <ahcorde@gmail.com>

* update

Signed-off-by: ahcorde <ahcorde@gmail.com>

* initialize variables

Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Jun 30, 2021
[Forwardport ros2] Duplicated code RobotJoint (#702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants