-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mass property visualization #714
Conversation
Visual representation is based on gazebo, i.e. visualize mass as equivalent lead ball and inertia as box.
This pull request will resolve ros-visualization/rviz#1204 |
Could someone independently verify that the mass and inertia visualization shapes match gazebo, for the UR model? Note: The color will not match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already tested it with some models and it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows is failing:
15:39:05 C:\ci\ws\src\ros2\rviz\rviz_default_plugins\src\rviz_default_plugins\robot\robot_link.cpp(833,65): error C2065: 'M_PI': undeclared identifier [C:\ci\ws\build\rviz_default_plugins\rviz_default_plugins.vcxproj]
Hi @briansoe66 , do you think you will have some time to fix this ? |
@ahcorde , I have committed a fix for the undefined M_PI on windows, but I have no windows computer to verify it worked. |
thnk you @briansoe66, let's try again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@briansoe66, appreciate your work, thanks! |
Can someone please explain how to get this to work? |
@jose-adrian, if you want to visualize the mass, you should include the plugin Anyhow please ask this kind of questions in https://answers.ros.org/questions/ |
Thanks for the answer! The problem is that I can't get those Mass Properties check boxes to appear in the RobotModel. Sorry to ask here but no luck in the ros forums, anyhow, I'll try again. Thanks! |
Add mass properties to robot model display, robot, and robot link.
Visual representation is based on gazebo,
i.e. visualize mass as equivalent lead ball and inertia as box, located at center of mass.
Changes are based on: vstuhumanoid/rviz@f215b91