Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mass property visualization #714

Merged
merged 6 commits into from
Jul 19, 2021
Merged

mass property visualization #714

merged 6 commits into from
Jul 19, 2021

Conversation

briansoe66
Copy link
Contributor

@briansoe66 briansoe66 commented Jun 22, 2021

Add mass properties to robot model display, robot, and robot link.
Visual representation is based on gazebo,
i.e. visualize mass as equivalent lead ball and inertia as box, located at center of mass.

Changes are based on: vstuhumanoid/rviz@f215b91

Visual representation is based on gazebo,
i.e. visualize mass as equivalent lead ball and inertia as box.
@briansoe66
Copy link
Contributor Author

This pull request will resolve ros-visualization/rviz#1204

@briansoe66
Copy link
Contributor Author

Could someone independently verify that the mass and inertia visualization shapes match gazebo, for the UR model? Note: The color will not match.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already tested it with some models and it looks good!

@ahcorde
Copy link
Contributor

ahcorde commented Jul 13, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows is failing:

15:39:05 C:\ci\ws\src\ros2\rviz\rviz_default_plugins\src\rviz_default_plugins\robot\robot_link.cpp(833,65): error C2065: 'M_PI': undeclared identifier [C:\ci\ws\build\rviz_default_plugins\rviz_default_plugins.vcxproj]

@ahcorde
Copy link
Contributor

ahcorde commented Jul 14, 2021

Hi @briansoe66 ,

do you think you will have some time to fix this ?

@briansoe66
Copy link
Contributor Author

Hi @briansoe66 ,

do you think you will have some time to fix this ?

@ahcorde , I have committed a fix for the undefined M_PI on windows, but I have no windows computer to verify it worked.

@ahcorde
Copy link
Contributor

ahcorde commented Jul 16, 2021

thnk you @briansoe66, let's try again

  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Jul 19, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ahcorde ahcorde merged commit 2b551f8 into ros2:ros2 Jul 19, 2021
@aemarkov
Copy link

@briansoe66, appreciate your work, thanks!

@chapulina chapulina mentioned this pull request Aug 11, 2021
@jose-adrian
Copy link

Can someone please explain how to get this to work?

@ahcorde
Copy link
Contributor

ahcorde commented Nov 3, 2021

@jose-adrian, if you want to visualize the mass, you should include the plugin RobotModeland configure it, Then you should click in mass Properties -> Mass. Like in this small gif

mass_rviz

Anyhow please ask this kind of questions in https://answers.ros.org/questions/

@jose-adrian
Copy link

Thanks for the answer! The problem is that I can't get those Mass Properties check boxes to appear in the RobotModel. Sorry to ask here but no luck in the ros forums, anyhow, I'll try again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants