Robot: Report mesh loading issues #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
clalancette
reviewed
Sep 15, 2021
| @@ -179,6 +179,8 @@ void RobotLinkSelectionHandler::postRenderPass(uint32_t pass) | |||
| } | |||
| } | |||
|
|
|||
| static std::map<const RobotLink *, std::string> errors; | |||
There was a problem hiding this comment.
I have to say that this seems like a weird way to do this. Can't we just have std::string error as a member variable in the RobotLink class?
Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette
approved these changes
Sep 17, 2021
| vsnprintf(buffer, sizeof(buffer), format, args); | ||
| va_end(args); | ||
|
|
||
| std::string & err = const_cast<std::string &>(getGeometryErrors()); |
There was a problem hiding this comment.
Nit: Since this is all in the same class, can we just use the error member variable instead (rather than calling a method and doing the cast)?
Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette
approved these changes
Sep 17, 2021
|
delete-merged-branch
bot
deleted the
ahcorde/report_mesh_loading_issues
branch
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2021-9-16/22372/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
This PR is related to this PR ros-visualization/rviz#1629 in RVIZ 1.
This PR will allow to visualize the errors of an invalid URDF in the RVIZ 2 GUI.