Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed inertia with ignition-math #751

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Computed inertia with ignition-math #751

merged 2 commits into from
Sep 22, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 24, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

Related with this issue #740

@ahcorde
Computed inertia with ignition-math
44ef166 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 24, 2021
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 24, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request Aug 26, 2021
Merged
@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 26, 2021

Relaunched CI with this PR ros2/ros2#1172 in ros2/ros2

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Aug 27, 2021

  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 14, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 14, 2021 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows Debug Build Status
  • CentOS Build Status

jacobperron
jacobperron reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple style related comments below.

Besides that, I'm okay with adding the new dependency, but would like a +1 from other maintainers.

rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp Outdated Show resolved Hide resolved
rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp Outdated Show resolved Hide resolved
rviz_default_plugins/src/rviz_default_plugins/robot/robot_link.cpp Outdated Show resolved Hide resolved
@ahcorde
Style
ad247a4 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 21, 2021

Besides that, I'm okay with adding the new dependency, but would like a +1 from other maintainers.

@clalancette @mjeronimo

@mjeronimo
Copy link
Contributor

Seems like a convenient library to use. +1

@ahcorde ahcorde merged commit c7ade57 into ros2 Sep 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/ignitionmath/inertia branch September 22, 2021 15:58
@jacobperron jacobperron mentioned this pull request Sep 28, 2021
Closed
@destogl
Copy link
Contributor

destogl commented Jan 21, 2022 •
edited
Loading

@ahcorde since this is merged, my colleagues and I are getting constantly error "The link is static or has unrealistic inertia, so the equivalent inertia box will not be shown". Thought, it is not obvious to me why this should be an error. I don't see any changes in rviz behavior than before. On the other hand to have simulation working properly inertia-values are very important so this seems to be in collision with this. What I don't understand about this? Are there any resources how to do this properly to have correct simulation and avoid this rviz error?

@ahcorde
Copy link
Contributor Author

ahcorde commented Jan 21, 2022

@destogl do you mind to open an issue ?

we can discuss there this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron left review comments

@clalancette clalancette clalancette approved these changes

@mjeronimo mjeronimo mjeronimo approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahcorde @mjeronimo @destogl @clalancette @jacobperron