Fixed crash when changing rendering parameters for pointcloud2 while 'Selectable' box is unchecked #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'Selectable' box is unchecked Signed-off-by: ahcorde <ahcorde@gmail.com>
mjeronimo
approved these changes
Sep 21, 2021
clalancette
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
This change looks good to me with green CI.
I am somewhat concerned about the integrity of the cloud_infos_ member variable. There is a new_clouds_mutex lock which suggests to me that these callbacks can be called in multiple threads, but I don't know that for certain. It's probably something we should investigate, though it doesn't prevent this particular fix from going in.
|
ahcorde
added a commit
that referenced
this pull request
Sep 22, 2021
…'Selectable' box is unchecked (#768) Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Sep 22, 2021
…'Selectable' box is unchecked (#768) Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
Fixed #669