Drop ignition-math6 from rviz_default_plugins link interface #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the rviz_default_plugins ABI relies on consumers linking against ignition-math6 directly. The alternative is to add the ignition-math6 link directory to the rviz_default_plugins link interface so that consumers can reliably find the library. Signed-off-by: Scott K Logan <logans@cottsay.net>
|
Rpr job is going to fail here until we do a new release of geometry2. I'll put that on the list to do, but we can ignore the failure for now. |
clalancette
approved these changes
Feb 22, 2022
Noted, thanks.
I added RHEL CI as well, thanks. |
|
aarch64 warnings are coming from Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the rviz_default_plugins ABI relies on consumers linking against ignition-math6 directly.
The alternative is to add the ignition-math6 link directory to the rviz_default_plugins link interface so that consumers can reliably find the library.
This isn't a problem on Ubuntu where the vendor package isn't built, but on RHEL, packages downstream of
rviz_default_pluginsfail to link because they can't find-lignition-math6.