Consider region of interest in CameraDisplay #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Sep 7, 2022
rviz_default_plugins/src/rviz_default_plugins/displays/camera/camera_display.cpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/include/rviz_default_plugins/displays/camera/camera_display.hpp
Outdated
Show resolved
Hide resolved
AndreasR30
force-pushed
the
origin-fork/ros2
branch
from
942aeb7
to
7e4383c
Compare
|
@jacobperron Thank you very much for your feedback. I added your suggestions. |
AndreasR30
force-pushed
the
origin-fork/ros2
branch
from
7e4383c
to
9b30006
Compare
|
I applied uncrustify and found that I overlooked one more formatting issue. Now it should be fine. |
jacobperron
reviewed
Sep 19, 2022
rviz_default_plugins/src/rviz_default_plugins/displays/camera/camera_display.cpp
Outdated
Show resolved
Hide resolved
This feature was already implemented in Rviz1
AndreasR30
force-pushed
the
origin-fork/ros2
branch
from
9b30006
to
e638fa2
Compare
jacobperron
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this commit considers the region of interest (roi) in CameraInfo.msg. It accounts for the fact that an image was cropped by the camera driver to reduce the required bandwidth. The values in CameraInfo.msg are the same as for the full image. Just the ROI values are set to non-zero values. This was already implemented in Rviz1. So I took these lines.