Show link names in inertia error message #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now the warning message is additionally suppressed for the base link and static links because it is common for them to not have an inertia, but it needs to be set in the urdf for some other programs, e.g. pybullet. |
Signed-off-by: Timon Engelke <timon.engelke@online.de>
|
@timonegk Can you please fix the linter warnings? With that done, we can consider this for inclusion. |
Signed-off-by: Timon Engelke <timon.engelke@online.de>
|
@clalancette they are fixed |
jacobperron
approved these changes
Aug 31, 2022
|
The unstable Windows result has nothing to do with this PR, so I'll go ahead and merge. |
Merged
christophfroehlich
pushed a commit
to christophfroehlich/rviz
that referenced
this pull request
Dec 7, 2023
* Show link names in inertia error message * Suppress warning message for base link and static links Signed-off-by: Timon Engelke <timon.engelke@online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #872.