Fix MeshResourceMarker for mesh with color-based embedded material #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to test this PR , I used this repo https://github.com/xbroquer/rviz_collada_marker/tree/ros2
|
|
Hello @ahcorde, is it possible to review this PR ? it will be great if this could be in the coming humble sync :) Thanks! |
clalancette
approved these changes
Dec 22, 2022
clalancette
requested changes
Dec 22, 2022
Comment on lines
251
to
252
| if (tinting) | ||
| { |
There was a problem hiding this comment.
Actually, CI is complaining about the style here. This should be:
Suggested change
| if (tinting) | |
| { | |
| if (tinting) { |
Comment on lines
260
to
262
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
Suggested change
| } | |
| else | |
| { | |
| } else { |
xbroquer
force-pushed
the
ros2-#927
branch
2 times, most recently
from
a093623
to
dc4a3ef
Compare
Issue: Colors from embedded color based mesh are overridden and not rendered as expected It was a known issue on ROS1 that was fixed by ros-visualization/rviz#1424 Kudos to the original author Fix ros2#927 Signed-off-by: Xavier BROQUERE <xav.broquere@gmail.com>
clalancette
approved these changes
Jan 2, 2023
|
CI:
|
|
Hi @clalancette , Thanks |
It looks like it preserves ABI and API, so yes, we can backport it. I'll ask the bot to do it. |
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
) Issue: Colors from embedded color based mesh are overridden and not rendered as expected It was a known issue on ROS1 that was fixed by ros-visualization/rviz#1424 Kudos to the original author Fix #927 Signed-off-by: Xavier BROQUERE <xav.broquere@gmail.com> (cherry picked from commit 2cb54fc)
clalancette
pushed a commit
that referenced
this pull request
May 12, 2023
) (#964) Issue: Colors from embedded color based mesh are overridden and not rendered as expected It was a known issue on ROS1 that was fixed by ros-visualization/rviz#1424 Kudos to the original author Fix #927 Signed-off-by: Xavier BROQUERE <xav.broquere@gmail.com> (cherry picked from commit 2cb54fc) Co-authored-by: Xavier BROQUERE <xav.broquere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Color from embedded color based mesh are overrided and not rendered as expected
It was an known issue on ROS1 that was fixed by
ros-visualization/rviz#1424
Kudos to the original author
Fix #927
Signed-off-by: Xavier BROQUERE xav.broquere@gmail.com