Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

points_marker: fix bug where points are never cleared #949

Merged
merged 1 commit into from
Feb 28, 2023
Merged

points_marker: fix bug where points are never cleared #949

merged 1 commit into from
Feb 28, 2023

Conversation

AndreasR30
Copy link
Contributor

Hello,

this fixes a bug where a vector of points is never cleared. With each step more and more points are added. This fixes #790 and maybe other issues with Marker in rviz. The example node in #790 works fine after this pull request.

@clalancette clalancette self-assigned this Feb 23, 2023
clalancette
clalancette approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable bugfix to me, thanks.

@clalancette clalancette changed the base branch from ros2 to rolling February 24, 2023 17:44
@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 1961b81 into ros2:rolling Feb 28, 2023
@james-yoo
Copy link

Hi,
Please backport this patch to humble branch.

Thanks

@clalancette
Copy link
Contributor

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Aug 11, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 11, 2023
@AndreasR30 @mergify
point_marker: fix bug where the number of rendered points accumulates…
85d6977 
… over time (#949)

(cherry picked from commit 1961b81)
@mergify mergify bot mentioned this pull request Aug 11, 2023
Merged
clalancette pushed a commit that referenced this pull request Aug 11, 2023
@mergify @AndreasR30
point_marker: fix bug where the number of rendered points accumulates…
198547c 
… over time (#949) (#1029)

(cherry picked from commit 1961b81)

Co-authored-by: AndreasR30 <andreas.reich@unibw.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

major performance issues marker cube_list
3 participants
@AndreasR30 @clalancette @james-yoo