If vendored assimp is present, always prefer that #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing behavior is to always prefer the system's assimp package if it is sufficient, even if the vendored assimp package is present. This is very confusing behavior when combined with FORCE_BUILD_VENDOR_PKG. Additionally, the double find_package calls can result in strange behavior if both calls deal create or modify targets, as targets created by the first call will be present when the second call tries to create them. Signed-off-by: Scott K Logan <logans@cottsay.net>
Merged
clalancette
approved these changes
Apr 17, 2023
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
|
@ros-pull-request-builder retest this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behavior is to always prefer the system's assimp package if it is sufficient, even if the vendored assimp package is present. This is very confusing behavior when combined with
FORCE_BUILD_VENDOR_PKG.Additionally, the double find_package calls can result in strange behavior if both calls create or modify targets, as targets created by the first call will be present when the second call tries to create them.