Add a libqt5-svg dependency to rviz_common. #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviz_common is the package that loads in various icons in svg format. In order to have them definitely be loaded in, make sure to depend on libqt5-svg. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
ahcorde
approved these changes
Jun 9, 2023
|
do we need to backport this ? @clalancette |
Yeah, we should backport to both Humble and Iron. I'll ask the bot to do it. |
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
rviz_common is the package that loads in various icons in svg format. In order to have them definitely be loaded in, make sure to depend on libqt5-svg. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit a7b8784)
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
rviz_common is the package that loads in various icons in svg format. In order to have them definitely be loaded in, make sure to depend on libqt5-svg. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit a7b8784)
This was referenced Jun 11, 2023
ahcorde
added a commit
that referenced
this pull request
Jun 20, 2023
Add a libqt5-svg dependency to rviz_common. (backport #992)
ahcorde
added a commit
that referenced
this pull request
Jun 23, 2023
Add a libqt5-svg dependency to rviz_common. (backport #992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rviz_common is the package that loads in various icons in svg format. In order to have them definitely be loaded in, make sure to depend on libqt5-svg.
This should fix #987