Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ament_cmake_vendor_package #995

Merged
merged 1 commit into from Jun 23, 2023
Merged

Switch to ament_cmake_vendor_package #995

merged 1 commit into from Jun 23, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 15, 2023

Part of ament/ament_cmake#429

This is the biggest of the vendoring changes. I find it easier to ignore the diffs and just inspect the before/after.

  • Linux Build Status
  • Linux Build Status (FORCE_BUILD_VENDOR_PKG)
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status
  • Windows Build Status

@cottsay
Switch to ament_cmake_vendor_package
1c1bfd7 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested a review from clalancette June 15, 2023 19:50
@cottsay cottsay self-assigned this Jun 15, 2023
@cottsay cottsay requested a review from ahcorde as a code owner June 15, 2023 19:50
@cottsay cottsay mentioned this pull request Jun 15, 2023
Merged
@cottsay
Copy link
Member Author

cottsay commented Jun 22, 2023 •
edited

@ros-pull-request-builder retest this please

1 similar comment
@cottsay
Copy link
Member Author

cottsay commented Jun 22, 2023

@ros-pull-request-builder retest this please

@clalancette clalancette mentioned this pull request Jun 22, 2023
Closed
@cottsay
Copy link
Member Author

cottsay commented Jun 22, 2023

This is blocked on a release of ignition_math6_vendor.

@cottsay
Copy link
Member Author

cottsay commented Jun 23, 2023

@ros-pull-request-builder retest this please

@cottsay cottsay merged commit 4e06de1 into rolling Jun 23, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/ament_vendor branch June 23, 2023 04:12
@clalancette
Copy link
Contributor

Just as an FYI, this seems to have broken the clang_libcxx build: https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1558/ . It's not important enough to revert, but I would appreciate a quick look to see if it is an easy fix.

@clalancette clalancette mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cottsay @clalancette @ahcorde